一些findbugs告警解决-Toy模板网

这篇具有很好参考价值的文章主要介绍了一些findbugs告警解决。希望对大家有所帮助。如果存在错误或未考虑完全的地方，请大家不吝赐教，您也可以点击"举报违法"按钮提交疑问。

WA_NOT_IN_LOOP/NAKED_NOTIFY/UNCOND_WAIT

这几个告警涉及到wait和notify的使用方法，网上文章语焉不详的，这里记录一下怎么处理。

WA_NOT_IN_LOOP：wait要在loop循环里。
NAKED_NOTIFY：notify/notifyAll调用之前要把资源准备好、把状态设置好，不能只调notify/notifyAll本身。
UNCOND_WAIT：跟WA_NOT_IN_LOOP其实是一个问题，wait要在loop循环里，且有一个条件变量控制

主要根因是，线程有可能被虚假的唤醒（spurious notify），这时需要一个条件变量确保其再次陷入等待。

摘了SO上的一段描述：

The problem is that you're trying to use wait and notify in ways that they are not designed to be used. Usually, wait and notify are used to have one thread wait until some condition is true, and then to have another thread signal that the condition may have become true. For example, they're often used as follows:

/* Producer */
synchronized (obj) {
    /* Make resource available. 这里要有条件变量设置的代码 */
    obj.notify();
}

/* Consumer */
synchronized (obj) {
    while (/* resource not available 这里要有条件变量就绪的判断，规避虚假唤醒问题 */) {
        obj.wait();
    }    

    /* Consume the resource. */
}
The reason that the above code works is that it doesn't matter which thread runs first. If the producer thread creates a resource and no one is waiting on obj, then when the consumer runs it will enter the while loop, notice that the resource has been produced, and then skip the call to wait. It can then consume the resource. If, on the other hand, the consumer runs first, it will notice in the while loop that the resource is not yet available and will wait for some other object to notify it. The other thread can then run, produce the resource, and notify the consumer thread that the resource is available. Once the original thread is awoken, it will notice that the condition of the loop is no longer true and will consume the resource.

More generally, Java suggests that you always call wait in a loop because of spurious notifications in which a thread can wake up from a call to wait without ever being notified of anything. Using the above pattern can prevent this.

总结起来，要将条件变量的设置+notify一起用synchronized包起来，将条件变量的while判断+wait一起用synchronized包起来，才能做到正确的使用wait/notify。
下面是一段常见的伪码样例：文章来源地址https://www.toymoban.com/news/detail-549567.html

@PreDestroy
public void fini() {
    synchronized (this) {
        this.isStopped = true;
        this.notifyAll();
    }
}

public void trigger(Event event) {
    synchronized (this) {
        this.isInProgress = event.hasSomeFlag();

        if (!this.isInProgress) {
            this.notifyAll();
        }
    }
}

public void wait4Sth() {
    synchronized (this) {
        while (this.isInProgress && !isStopped) {
            try {
                this.wait();
            } catch (InterruptedException e) {
                log.warn("wait4Sth interrupted, cause:{}", e.toString());
            }
        }
    }
}